build(eslint): enable linting hidden folders #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESlint by default ignore folders with a name that start with a dot like .storybook and .playground. This will un-ignore those folders allowing eslint capabilities on editor also on these folders.
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 38 38
Lines 2814 2814
Branches 666 666
=======================================
Hits 2765 2765
Misses 44 44
Partials 5 5Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Oct 2, 2019
|
PS this was my solution 👇 // settings.json
{
"eslint.workingDirectories": [
{ "directory": "/Users/nicholaspartridge/Documents/repos/elastic-charts/.playground",
"changeProcessCWD": true },
{ "directory": "/Users/nicholaspartridge/Documents/repos/elastic-charts/.storybook",
"changeProcessCWD": true }
],
} |
|
🎉 This PR is included in version 13.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ESlint by default ignore folders with a name that start with a dot like .storybook and .playground.
This will un-ignore those folders allowing eslint capabilities on editor also on these folders.
see eslint/eslint#8429 (comment)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios