-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart_state): add render change event #365
feat(chart_state): add render change event #365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 98.26% 98.27% +<.01%
==========================================
Files 38 38
Lines 2772 2782 +10
Branches 654 656 +2
==========================================
+ Hits 2724 2734 +10
Misses 44 44
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only small addition I wouldn't mind is an explanation of the significance of the true
and false
values that get emitted
Good point I added the type here but an explanation would be good
|
@markov00 when you return, could you please look at this to see if the timing logic is correct? I was thinking to put the trigger on the mount/update of the reactive_chart component but the timing was virtually identical to observing the |
# [11.2.0](v11.1.2...v11.2.0) (2019-09-04) ### Features * **chart_state:** add render change event ([#365](#365)) ([521889b](521889b))
🎉 This PR is included in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [11.2.0](elastic/elastic-charts@v11.1.2...v11.2.0) (2019-09-04) ### Features * **chart_state:** add render change event ([opensearch-project#365](elastic/elastic-charts#365)) ([4257159](elastic/elastic-charts@4257159))
Summary
Add render change (
onRenderChange
) lifecycle hook toSettings
.onRenderChange
is a listener to be called when chart render state changes.isRendered
value istrue
when rendering is complete andfalse
otherwise.Required to implement visualization count for Discover and TSVB.
http://localhost:9001/?path=/story/interactions--render-change-action
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)