fix(renderer): stroke opacity #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markov00 a strange consequence of this is when stacking bars the bar segments don't look as uniform.
|
nickofthyme
force-pushed
the
fix/bar-styles
branch
from
83d0f6a to
f481518
Compare
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 98.27% 98.28% +<.01%
==========================================
Files 38 38
Lines 2729 2737 +8
Branches 643 644 +1
==========================================
+ Hits 2682 2690 +8
Misses 43 43
Partials 4 4
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Aug 26, 2019
## [11.0.1](v11.0.0...v11.0.1) (2019-08-26) ### Bug Fixes * **renderer:** stroke opacity ([#335](#335)) ([d8c8459](d8c8459))
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [11.0.1](elastic/elastic-charts@v11.0.0...v11.0.1) (2019-08-26) ### Bug Fixes * **renderer:** stroke opacity ([opensearch-project#335](elastic/elastic-charts#335)) ([6f35fa0](elastic/elastic-charts@6f35fa0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #323
Fix stoke opacity on bar charts.
Add a property for
strokeOpacityonRectBorderStyle. Fallback usesopacityonRectStyle.If
strokeOpacityis provided theunhighlightedstoke opacity is averaged between the provided value and the globalunhighlightedopacity value.This change requires splitting the fill and stroke into TWO separate
Rectelements as the KonvaRectAPI does not allow for stroke opacity but forces inheritance from the fill opacity.Currently, the
perfectDrawEnabledis set tofalsewhich causes the border to overlap the fill. These changes inset the border/stroke inside of the filled rectangle/bar. https://konvajs.org/docs/performance/Disable_Perfect_Draw.htmlDemo
Checklist