fix(tooltip): fix duplicate key warning for band area charts #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A band area chart has the same seriesKey for the Y0 and Y1 values. This cause the tooltip to emit a warning because of two react components with the same key. This commit fix that adding the accessor value as part of the react key fix elastic#326
markov00
added
:interactions
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 98.05% 98.06% +0.01%
==========================================
Files 38 38
Lines 2726 2742 +16
Branches 643 650 +7
==========================================
+ Hits 2673 2689 +16
Misses 48 48
Partials 5 5
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Aug 19, 2019
|
🎉 This PR is included in version 9.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [9.2.1](elastic/elastic-charts@v9.2.0...v9.2.1) (2019-08-20) ### Bug Fixes * **tooltip:** fix duplicate key warning for band area charts ([#327](elastic/elastic-charts#327)) ([c6c7aa1](elastic/elastic-charts@c6c7aa1)), closes [opensearch-project#326](elastic/elastic-charts#326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A band area chart has the same seriesKey for the Y0 and Y1 values. This cause the tooltip to emit a warning because of two react components with the same key. This commit fix that adding the accessor value as part of the react key.
fix #326
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)