Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): disable fade other if legend item is not visible #321

Closed

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 16, 2019

Summary

When hovering on a legend item that is currently hidden, don't fade the other series https://d.pr/free/i/DbbyWC

TODO

The current status correctly avoid hiding the other series when mouse over an hidden one:
Oct-29-2019 18-07-38

What is missing is the following: fade in all the series right after I clicked a series in the legend. Currently, if you click to hide a series, the rendered series are in a fade status. We need to have a consistent behaviour and, right after a click I just want to hide the clicked series and also I want to see all the other clearly

wrong behaviour
Oct-29-2019 18-11-35

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@markov00 markov00 mentioned this pull request Aug 16, 2019
25 tasks
@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #321 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +<.01%     
==========================================
  Files          37       37              
  Lines        2715     2719       +4     
  Branches      636      638       +2     
==========================================
+ Hits         2662     2666       +4     
  Misses         48       48              
  Partials        5        5
Impacted Files Coverage Δ
src/chart_types/xy_chart/store/chart_state.ts 96.91% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f13dd...48882d3. Read the comment docs.

@nickofthyme
Copy link
Collaborator

@markov00 Did you want to add anything more to this PR?

@nickofthyme nickofthyme closed this Nov 1, 2019
@markov00 markov00 deleted the mouseover-deselected-series branch November 25, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants