-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(legend): item hideInLegend prop #307
Conversation
Fix hideInLegend prop to work again fix elastic#306
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 37 37
Lines 2684 2684
Branches 632 632
=======================================
Hits 2635 2635
Misses 44 44
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
BTW I've a linked feature request: |
@markov00 sounds good 👍 |
🎉 This PR is included in version 9.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [9.0.4](elastic/elastic-charts@v9.0.3...v9.0.4) (2019-08-13) ### Bug Fixes * **legend:** item hideInLegend prop ([opensearch-project#307](elastic/elastic-charts#307)) ([fdfc694](elastic/elastic-charts@fdfc694)), closes [opensearch-project#306](elastic/elastic-charts#306)
Summary
Fix
hideInLegend
prop to work againfix #306 -- I saw another issue for this a few weeks back but couldn't find it.
Before
After
Checklist