fix(ChartStatus): render complete if same parent size is dispatched #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
approved these changes
Sep 30, 2024
nickofthyme
pushed a commit
that referenced
this pull request
Oct 3, 2024
## [67.0.1](v67.0.0...v67.0.1) (2024-10-03) ### Bug Fixes * **ChartStatus:** render complete if same parent size is dispatched ([#2534](#2534)) ([c3aba88](c3aba88))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A PR in Kibana identified a bug in our current code (and probably also in the ResizeObserver API). This PR showed that the ResizeObserver can dispatch the same witdh/height/left/top values under certain circumstances (not really clear from the PR).
In code we don't have a check for this case thus a duplicated
updateParentDimensionaction can be dispatched causing the chart to remain in a wrong state: therenderedComplete:falsebut the chart still rendered on the screen. The configured chart renderer doesn't get triggered because the parentDimension in effect is not changed, thus the render count doesn't increase and no dispatch toonRenderCompleteis issued, causing a wrong ChartStatus to be reported.The fix just trigger a
UPDATE_PARENT_DIMENSIONstate change only if the dimensions are different.