Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error with RecursivePartial #248

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

nickofthyme
Copy link
Collaborator

Summary

Fixes type error in Kibana for v7.0.0

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          36       36           
  Lines        2636     2636           
  Branches      588      588           
=======================================
  Hits         2577     2577           
  Misses         52       52           
  Partials        7        7
Impacted Files Coverage Δ
src/lib/utils/commons.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cf000...2082ef1. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you want to check this in kibana before merging?

@nickofthyme
Copy link
Collaborator Author

Tested in kibana and running node scripts/type_check.js passes all checks

@nickofthyme nickofthyme merged commit f2b90df into elastic:master Jun 25, 2019
@nickofthyme nickofthyme deleted the fix/type-error-rec-partial branch June 25, 2019 16:22
@markov00 markov00 added the chore label Jun 25, 2019
markov00 pushed a commit that referenced this pull request Jun 25, 2019
## [7.0.1](v7.0.0...v7.0.1) (2019-06-25)

### Bug Fixes

* type error with RecursivePartial ([#248](#248)) ([f2b90df](f2b90df))
@markov00
Copy link
Member

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 25, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants