-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legend): improve tooltip wording #2439
Merged
nickofthyme
merged 11 commits into
elastic:main
from
dej611:feat/update-interaction-labels
Jun 3, 2024
Merged
feat(legend): improve tooltip wording #2439
nickofthyme
merged 11 commits into
elastic:main
from
dej611:feat/update-interaction-labels
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
:legend
Legend related issue
:accessibility
Accessibility related issue
:xy
Bar/Line/Area chart related
labels
May 21, 2024
nickofthyme
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, just mentioned 2 ideas I think would improve the appearance.
cc: @gvnmagni
Co-authored-by: Nick Partridge <[email protected]>
nickofthyme
reviewed
May 21, 2024
mbondyra
approved these changes
May 29, 2024
nickofthyme
reviewed
Jun 3, 2024
nickofthyme
pushed a commit
that referenced
this pull request
Jun 4, 2024
# [65.2.0](v65.1.0...v65.2.0) (2024-06-04) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^94.5.2 ([#2450](#2450)) ([26b425c](26b425c)) * **deps:** update dependency @elastic/eui to ^94.6.0 ([#2454](#2454)) ([6759469](6759469)) * **deps:** update dependency @playwright/test to ^1.44.1 ([#2451](#2451)) ([158b4c2](158b4c2)) * **deps:** update dependency json-schema-to-typescript to v14.0.5 ([#2452](#2452)) ([7947e17](7947e17)) * **metric:** chart not rendered when the trend is empty ([#2447](#2447)) ([6042cc8](6042cc8)) * **sunburst:** rendering for full sections ([#2457](#2457)) ([58c2721](58c2721)) ### Features * **legend:** improve tooltip wording ([#2439](#2439)) ([27c04f4](27c04f4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:accessibility
Accessibility related issue
:legend
Legend related issue
:xy
Bar/Line/Area chart related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The legend title tooltip wording has been improved to be clearer.
Details
Improved the wording as described in #2438
Issue
closes #2438