Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(legend): select legend statistic value #2355

Merged
merged 18 commits into from
Apr 9, 2024
Merged

feat(legend): select legend statistic value #2355

merged 18 commits into from
Apr 9, 2024

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Mar 11, 2024 •
edited
Loading

Summary

This PR paved the way for the new legend design.
The following tasks are implemented

  • renamed the showLegendExtra to be a more generic legendValues (breaking change)
  • the legendValues accept an array of LegendValue that is an ordered set of statistics to use (breaking change)
  • all the possible legend aggregations (defined in [Meta] Statistics in chart legends kibana#176583) are implemented
  • the current legend implement still works and will only show the first LegendValue defined.

BREAKING CHANGE

The showLegendExtra prop in the Settings is renamed to legendValues and accept an array of LegendValues.

Details

Current VRT changes are related to the change of the depth parameter in the LegendItem that by default is now zero indexed, instead of 1 as it was before for partition charts.

Issues

Fix #561
Initial part of elastic/kibana#176583

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with light and dark themes

@markov00 markov00 added enhancement New feature or request :legend Legend related issue :all Applies to all chart types labels Mar 12, 2024
@markov00 markov00 changed the title feat(legend): new design feat(legend): select legend statistic value Mar 13, 2024
@markov00
Copy link
Member Author

buildkite update screenshots

@markov00 markov00 marked this pull request as ready for review March 18, 2024 11:23
@markov00 markov00 mentioned this pull request Apr 8, 2024
Closed
@nickofthyme nickofthyme changed the base branch from main to alpha April 9, 2024 05:22
@nickofthyme nickofthyme changed the base branch from alpha to main April 9, 2024 05:23
@nickofthyme nickofthyme enabled auto-merge (squash) April 9, 2024 05:25
@nickofthyme nickofthyme merged commit a602838 into elastic:main Apr 9, 2024
14 checks passed
nickofthyme pushed a commit that referenced this pull request May 20, 2024
@semantic-release-bot
chore(release): 65.0.0 [skip ci]
4f266ca 
# [65.0.0](v64.1.0...v65.0.0) (2024-05-20)

### Bug Fixes

* **barSeries:** error rendering bars with negative log scale ([#2407](#2407)) ([4ab6d8f](4ab6d8f))
* **deps:** update dependency @elastic/eui to ^93.5.1 ([#2375](#2375)) ([35ed956](35ed956))
* **deps:** update dependency @elastic/eui to ^93.5.2 ([#2386](#2386)) ([e26c6dd](e26c6dd))
* **deps:** update dependency @elastic/eui to ^93.6.0 ([#2393](#2393)) ([40f2b7b](40f2b7b))
* **deps:** update dependency @elastic/eui to ^94.3.0 ([#2424](#2424)) ([cff5181](cff5181))
* **deps:** update dependency @elastic/eui to v94 ([#2409](#2409)) ([67c814f](67c814f))
* **deps:** update dependency @playwright/test to ^1.43.0 ([#2388](#2388)) ([42f86d7](42f86d7))
* **deps:** update dependency @playwright/test to ^1.43.1 ([#2413](#2413)) ([79b1c7f](79b1c7f))
* **deps:** update dependency json-schema-to-typescript to v14 ([#2414](#2414)) ([785f635](785f635))
* **deps:** update dependency json-schema-to-typescript to v14.0.4 ([#2421](#2421)) ([790170a](790170a))
* **legend:** custom legend covered by background ([#2366](#2366)) ([5b9ffac](5b9ffac))

### Features

* add support for start day of week on MLT axis ([#2362](#2362)) ([3aac1f0](3aac1f0))
* **Legend:** change click on item behaviour ([#2427](#2427)) ([b1c72df](b1c72df))
* **legend:** change click on item behaviour ([#2431](#2431)) ([b03bdd0](b03bdd0))
* **legend:** Improve interactions legend labels ([#2418](#2418)) ([384baac](384baac))
* **legend:** select legend statistic value ([#2355](#2355)) ([a602838](a602838))
* **metric:** support array of values ([#2428](#2428)) ([e448bd7](e448bd7))

### Reverts

* **legend:** change click on item behaviour ([#2429](#2429)) ([cc438a1](cc438a1)), closes [#2427](#2427)

### BREAKING CHANGES

* **legend:** The legend modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.
@nickofthyme nickofthyme mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
:all Applies to all chart types breaking change enhancement New feature or request :legend Legend related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the legend extra parameter customizable
2 participants
@markov00 @nickofthyme