feat(metric): custom slot to render contents in gap #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite update screenshots |
markov00
approved these changes
Jan 24, 2024
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Jan 29, 2024
# [63.1.0](v63.0.0...v63.1.0) (2024-01-29) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^92.1.1 ([#2315](#2315)) ([f4e4fae](f4e4fae)) * **deps:** update dependency @playwright/test to ^1.41.1 ([#2316](#2316)) ([e2ab527](e2ab527)) * **styles:** isolated point style overrides ([#2278](#2278)) ([3fb1df2](3fb1df2)) ### Features * **metric:** custom slot to render contents in gap ([#2303](#2303)) ([3256c8c](3256c8c)) ### Performance Improvements * **tooltip:** improve placement logic ([#2310](#2310)) ([cac5f49](cac5f49))
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to render arbitrary contents into the gap space of the metric. This adds the optional
slotprop to theMetricspec.Details
The contents of the slot are contained inside of an absolutely positioned container to allow rendering contents without contents size impacting the layout of the Metric elements. Alternatively, we could add an option to disable this behavior ad allow the Metric elements to be pushed out of the render area or we could account for the slot size at the time of rendering.
Issues
closes #2182
Checklist
:xy,:partition)closes #123,fixes #123)packages/charts/src/index.tslightanddarkthemes