Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update font family #2165

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

markov00
Copy link
Member

Summary

Updating the font family to match the EUI one.

Issues

fix #2149

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@markov00 markov00 added enhancement New feature or request :styling Styling related issue :all Applies to all chart types labels Sep 12, 2023
@markov00 markov00 marked this pull request as ready for review September 12, 2023 10:23
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I kinda expected there to be some VRT updates. Is it just the same resolved font? Or Inter UI close enough to Inter?

@markov00
Copy link
Member Author

LGTM though I kinda expected there to be some VRT updates. Is it just the same resolved font? Or Inter UI close enough to Inter?

I'm not sure we are actually loading any font for the VRT, so it will, by default, fallback to the next available

@markov00 markov00 merged commit be07b0c into elastic:main Sep 13, 2023
@markov00 markov00 deleted the 2023_09_12-update_eui_font_family branch September 13, 2023 08:46
nickofthyme pushed a commit that referenced this pull request Sep 20, 2023
# [60.0.0](v59.1.0...v60.0.0) (2023-09-20)

### Bug Fixes

* **deps:** update dependency @elastic/eui to ^88.2.0 ([#2161](#2161)) ([6609a19](6609a19))
* **deps:** update dependency @elastic/eui to ^88.3.0 ([#2163](#2163)) ([624f43a](624f43a))
* **deps:** update dependency @elastic/eui to v85 ([#2113](#2113)) ([1b3fa7c](1b3fa7c))
* **deps:** update dependency @elastic/eui to v87 ([#2145](#2145)) ([312c32c](312c32c))
* **deps:** update dependency @elastic/eui to v88 ([#2154](#2154)) ([4070da0](4070da0))
* **tooltip:** rendering in react v18 ([#2169](#2169)) ([f30df54](f30df54))
* update font family ([#2165](#2165)) ([be07b0c](be07b0c))
* **waffle:** remove alpha artifacts ([#2139](#2139)) ([8eb4ede](8eb4ede))
* Wait a tick before reporting render status ([#2131](#2131)) ([fd2bca4](fd2bca4))
* **xy:** disable legend extra on ordinal ([#2114](#2114)) ([3ddfb18](3ddfb18))

### Features

* add locale prop to Settings ([#2164](#2164)) ([0bb3ab1](0bb3ab1))

### BREAKING CHANGES

* **xy:** when using the `ScaleType.Ordinal` for the X scale the legend extra value, representing the last and current hovered value, will not be shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:all Applies to all chart types enhancement New feature or request :styling Styling related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the EUI font family
2 participants