Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add jjbb jobs and utility script #205

Merged
merged 1 commit into from
May 30, 2019

Conversation

jonahbull
Copy link
Member

Add the definition for the pull request job so that it can be managed from this repo. The values in defaults.yml will be merged with the pull request definition. check_paths_for_matches is a utility script used to prevent unnecessary builds from happening on every push to master due to problems with the Jenkins git plugin.

Add the definition for the pull request job so that it can be managed
from this repo. The values in defaults.yml will be merged with the pull
request definition. `check_paths_for_matches` is a utility script used
to prevent unnecessary builds from happening on every push to master due
to problems with the Jenkins `git` plugin.
@jonahbull
Copy link
Member Author

This is part of the project to move JJB job definitions into the product repos themselves so they can be updated there without having to open PRs against the Infra repo.

cc: @spalger

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #205   +/-   ##
======================================
  Coverage    97.4%   97.4%           
======================================
  Files          35      35           
  Lines        2120    2120           
  Branches      315     323    +8     
======================================
  Hits         2065    2065           
  Misses         48      48           
  Partials        7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f257e...9cbe00d. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for that. From what I see seems everything in line, I've just added a minor comment for a typo.

So from now, if we need to add a new job is just a matter of yml file onthe .ci/jobs folder, right?

.ci/jobs/defaults.yml Show resolved Hide resolved
@jonahbull
Copy link
Member Author

@markov00 That's right, if you want to add jobs you can just drop them in the .ci/jobs directory.

@jonahbull
Copy link
Member Author

@markov00 If this looks okay I'd like to get it merged so I can wire up the jobs on the Infra side. Thanks!

@markov00 markov00 merged commit c566e2c into elastic:master May 30, 2019
cchaos pushed a commit to cchaos/elastic-charts that referenced this pull request Jun 4, 2019
Add the definition for the pull request job so that it can be managed
from this repo. The values in defaults.yml will be merged with the pull
request definition. `check_paths_for_matches` is a utility script used
to prevent unnecessary builds from happening on every push to master due
to problems with the Jenkins `git` plugin.
@markov00
Copy link
Member

markov00 commented Jun 5, 2019

🎉 This PR is included in version 4.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants