-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add jjbb jobs and utility script #205
Conversation
Add the definition for the pull request job so that it can be managed from this repo. The values in defaults.yml will be merged with the pull request definition. `check_paths_for_matches` is a utility script used to prevent unnecessary builds from happening on every push to master due to problems with the Jenkins `git` plugin.
This is part of the project to move JJB job definitions into the product repos themselves so they can be updated there without having to open PRs against the Infra repo. cc: @spalger |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
======================================
Coverage 97.4% 97.4%
======================================
Files 35 35
Lines 2120 2120
Branches 315 323 +8
======================================
Hits 2065 2065
Misses 48 48
Partials 7 7 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for that. From what I see seems everything in line, I've just added a minor comment for a typo.
So from now, if we need to add a new job is just a matter of yml
file onthe .ci/jobs
folder, right?
@markov00 That's right, if you want to add jobs you can just drop them in the |
@markov00 If this looks okay I'd like to get it merged so I can wire up the jobs on the Infra side. Thanks! |
Add the definition for the pull request job so that it can be managed from this repo. The values in defaults.yml will be merged with the pull request definition. `check_paths_for_matches` is a utility script used to prevent unnecessary builds from happening on every push to master due to problems with the Jenkins `git` plugin.
🎉 This PR is included in version 4.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add the definition for the pull request job so that it can be managed from this repo. The values in defaults.yml will be merged with the pull request definition.
check_paths_for_matches
is a utility script used to prevent unnecessary builds from happening on every push to master due to problems with the Jenkinsgit
plugin.