-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legend): expose legend extra configuration #2043
Draft
markov00
wants to merge
34
commits into
elastic:main
Choose a base branch
from
markov00:2023_05_17-fix_last_bucket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
changed the title
test:add example for last bucket error
test: add example for last bucket error
May 17, 2023
buildkite update screenshots |
BREAKING CHANGE: the has been replaced by a with multiple parameters
markov00
changed the title
test: add example for last bucket error
feat(legend): expose legend extra configuration
May 18, 2023
buildkite update screenshots |
markov00
force-pushed
the
2023_05_17-fix_last_bucket
branch
from
June 5, 2023 14:31
324daa2
to
340ba86
Compare
buildkite update screenshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR rewrites and exposes the configuration for the
legend extra
parameter, now calledlegend value
.These are the changes available in the PR:
showLegendExtra
prop inSettings
with a configurablelegendValue
legendValue
prop now accept the following configurations:none
: don't display a valuelastBucket
: works onlyTODO.....
extra
and extra related functions, replacing theextra
term withvalue
orvalues
. Extra wasn't a proper name and I feel thatvalue
is definitely generic but at least more specificAdd an example of the wrong rendering of the last bucket in data.
The example shows:
May 16, 2023 @ 00:00:00.000
to May17, 2023 @ 12:59:59.999
UTC+2Linked to elastic/kibana#153079 for a cleaner resolution of the problem
Details
Issues
Checklist
:xy
,:partition
):interactions
,:axis
):theme
label has been added and the@elastic/eui-team
team has been pinged when there areTheme
API changescloses #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light