fix(scales): improve ticks for time domains spanning a DST switch #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take current offset into account when shifting ticks back into the real domain to make sure ticks are placed correctly.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage ? 97%
=======================================
Files ? 35
Lines ? 1870
Branches ? 249
=======================================
Hits ? 1814
Misses ? 49
Partials ? 7
Continue to review full report at Codecov.
|
|
jenkins test this |
|
jenkins test this |
markov00
pushed a commit
that referenced
this pull request
May 3, 2019
## [4.0.2](v4.0.1...v4.0.2) (2019-05-03) ### Bug Fixes * **scales:** improve ticks for time domains spanning a DST switch ([#204](#204)) ([2713336](2713336))
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [4.0.2](elastic/elastic-charts@v4.0.1...v4.0.2) (2019-05-03) ### Bug Fixes * **scales:** improve ticks for time domains spanning a DST switch ([opensearch-project#204](elastic/elastic-charts#204)) ([12fc7b3](elastic/elastic-charts@12fc7b3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Take current offset into account when shifting ticks back into the real domain to make sure ticks are placed correctly.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials