Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate node-sass to latest sass #1618

Merged
merged 8 commits into from
Mar 4, 2022
Merged

build: migrate node-sass to latest sass #1618

merged 8 commits into from
Mar 4, 2022

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Mar 3, 2022 •
edited
Loading

Summary

  • Migrates build:sass command to use sass instead of node-sass.
  • Remove all ~ imports in src/ .scss files and remove node-sass-tilde-importer.
  • Upgrades storybook docs to use latest sass version.

@nickofthyme nickofthyme added :docs Anything related to documentation, API, storybook dependencies Pull requests that update a dependency file :build Build tools / dependencies labels Mar 3, 2022
@nickofthyme nickofthyme changed the title docs: upgrade sass version build: migrate node-sass to latest sass Mar 3, 2022
@nickofthyme nickofthyme requested a review from markov00 March 3, 2022 18:24
markov00
markov00 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when green!

@nickofthyme nickofthyme enabled auto-merge (squash) March 4, 2022 01:51
@nickofthyme nickofthyme merged commit 6a174cd into elastic:master Mar 4, 2022
@nickofthyme nickofthyme deleted the docs-upgrade-sass branch March 4, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
:build Build tools / dependencies dependencies Pull requests that update a dependency file :docs Anything related to documentation, API, storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickofthyme @markov00