fix(flamegraph): solve animation regression #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
added
:interactions
monfera
commented
Dec 29, 2021
| @@ -511,6 +512,7 @@ export function shapeViewModel( | |||
| pickQuads, | |||
| outerRadius, | |||
| chartDimensions, | |||
| animation, | |||
There was a problem hiding this comment.
This line is the actual fix, and the other change (restoring mandatory nature of the property) just ensures it can't get lost accidentally
rshen91
approved these changes
Dec 29, 2021
nickofthyme
pushed a commit
that referenced
this pull request
Jan 5, 2022
# [42.0.0](v41.0.1...v42.0.0) (2022-01-05) ### Bug Fixes * **flamegraph:** solve animation regression occurring with 6db2677 ([#1541](#1541)) ([5ec6037](5ec6037)), closes [#1540](#1540) * **heatmap:** render empty state ([#1532](#1532)) ([59002df](59002df)) * **waffle:** fix strange 0 text in legend item extra when label is 0 ([#1538](#1538)) ([72224b9](72224b9)) ### Features * **goal:** add valueFormatter for tooltip ([#1529](#1529)) ([8139973](8139973)) * **heatmap:** add axis titles ([#1503](#1503)) ([a87325d](a87325d)) * **types:** improve generic types in specs, and spec prop types ([#1421](#1421)) ([562929e](562929e)) ### BREAKING CHANGES * **types:** The `xAccessor` and `yAccessor` are now required on all xy chart specs. Stronger typing on `data` prop that may cause type errors when using untyped array (i.e. `const arr: never[] = []`). Other minor type changes related to spec types. * **heatmap:** The heatmap yAxisLabel.padding style type is changed from Pixel | Partial<Padding> to Pixels | Padding. The heatmap axis labels are now correctly subjected to padding calculations and it will result in a slightly different position of labels. Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restored tweening (animation) to flamegraph that stopped working at 6db2677
Details
The work that moved numerous config options into the theme turned the previously mandatory
animationproperty optional. This watered up preexisting TS type checks, as optionals often do, and we don't yet have mid-flight VRT for (currently alpha) animations, so it flew under the radar.The fix restores the mandatory nature of
animationand supplies a default zerodurationfor it.In the future it might become part of the theme, would need a convo.
Issues
Closes #1540
Checklist
:xy,:partition):interactions,:axis)The:themelabel has been added and the@elastic/eui-designteam has been pinged when there areThemeAPI changescloses #123,fixes #123)New public API exports have been added topackages/charts/src/index.tsThe proper documentation and/or storybook story has been added or updatedVisual changes have been tested with all available themes includingdark,light,eui-dark&eui-light