feat(line_annotation): add hideLines and hideTooltips props to spec #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 94.06% 94.07% +<.01%
==========================================
Files 34 34
Lines 1753 1755 +2
Branches 223 224 +1
==========================================
+ Hits 1649 1651 +2
Misses 90 90
Partials 14 14
Continue to review full report at Codecov.
|
emmacunningham
added
:annotation
markov00
approved these changes
Apr 8, 2019
markov00
pushed a commit
that referenced
this pull request
Apr 8, 2019
# [3.8.0](v3.7.2...v3.8.0) (2019-04-08) ### Features * **line_annotation:** add hideLines and hideTooltips props to spec ([#154](#154)) ([ba806b1](ba806b1))
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.8.0](elastic/elastic-charts@v3.7.2...v3.8.0) (2019-04-08) ### Features * **line_annotation:** add hideLines and hideTooltips props to spec ([opensearch-project#154](elastic/elastic-charts#154)) ([f9ebdec](elastic/elastic-charts@f9ebdec))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
re: #150
This PR introduces two props to LineAnnotationSpec:
hideLinesandhideTooltipswhich can be used to toggle visibility of annotation lines and their tooltips when set to true.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.