Code

refactor: DRY up measureText code#1535

Code

Merged

markov00 merged 15 commits intoelastic:masterelastic/elastic-charts:masterfrom markov00:2021_12_22-dry_textmeasuremarkov00/elastic-charts:2021_12_22-dry_textmeasureCopy head branch name to clipboardDec 24, 2021

+325-331

Commits

Commits on Dec 22, 2021

• Fix typo

  markov00

  committed
  e5f9f20

• Don't append measurement canvas to documentElement

  markov00

  committed
  ce0ab41

• Improve type on cssFontShorthand

  markov00

  committed
  c6fd0f0

• Use cssFontShorthand and actualBoundingBox on textMeasure

  markov00

  committed
  615b01b

• Remove duplicated measureText fn and type

  markov00

  committed
  3ec5b91

• Remove last direct use of measureText

  markov00

  committed
  76159c6

• Reduce pixel diff on node testing

  markov00

  committed
  345df7f

• Fix snapshot tests

  markov00

  committed
  4b85f94

Commits on Dec 23, 2021

• Avoid unnecessary text measurement if length is zero

  markov00

  committed
  098c86e

• Reuse the measureText code for the full geometries rendering phase

  markov00

  committed
  8b62993

• Update VRTs

  markov00

  committed
  e344f5d

Commits on Dec 24, 2021

• Remove shallow copy

  markov00

  committed
  6506c9f

• List single properties on call

  markov00

  committed
  24d19d5

• List only required props

  markov00

  committed
  9619398

• Fix not required falsy check

  markov00

  committed
  d606421