-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(xy): scale type improvements #1381
Merged
+140
−121
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
543c33c
chore: tick values are numbers
monfera 915c86f
chore: showing any via the generic type
monfera 9ed546a
chore: converting more any to unknown
monfera 12ef5a8
chore: converting more any to unknown 02
monfera c7f89b2
chore: converting more any to unknown 03
monfera 26d9935
chore: converting more any to unknown 04
monfera 8675664
chore: converting more any to unknown 05
monfera 2ae39b3
chore: converting more any to real type 06
monfera 57c5c8f
chore: converting more any to real type 07
monfera 3607f0a
chore: converting more any to real type 08
monfera ae17f5c
chore: converting more any to real type 09
monfera bb93b5a
chore: converting more any to real type 10
monfera 432238d
chore: converting more any to real type 11
monfera 9be0b6a
chore: converting more any to real type 12
monfera 770f3a6
chore: generic ScaleBand 01
monfera 44af026
chore: generic ScaleBand 02
monfera 6eea0f7
chore: generic ScaleBand 03
monfera 0ec33ef
chore: converting more any to real type 13
monfera 7272653
chore: converting more any to real type 14
monfera 5bc5c0a
chore: converting more any to real type 15
monfera 3e30380
chore: converting more any to real type 16
monfera 09bed4a
refactor: drive by removal of verbose code
monfera c20cef9
chore: converting more any to real type 17
monfera 0ac3fd2
test: type improvement round ht MarcoV NickP
monfera 8cd6cda
test: generic typing for isBandScale
monfera afaceb6
test: doing away with the unknown
monfera b59e2e0
test: more assertion removals due to review update ripple-down
monfera b36aefb
test: more any removals
monfera 640d644
test: all yScale occurrences are numeric
monfera 36d1596
test: minor other unifications
monfera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: generic ScaleBand 01
commit 770f3a60db7f667a481d7418ea024291afa955f3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we've already been cheating to comply with the D3 scale typedef file and the D3 doc, but now we're clear about it. I'll try to solve it in a next PR, it's only partially addressed in this one