-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup colors #1320
refactor: cleanup colors #1320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would suggest a slightest simplified API. See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to merge once it passes and conflicts are resolved
Switching to some color object (or fake enum) would be sensible if we expect significant growth to the count of these constants, or a COLOR_
prefix at least. With the current handful of colors, I don't feel strongly either way. Worth doing a last minute grep for all string occurrences 'black'
or even without quotes to ferret out template string occurrences or similar
just an update: I've found that |
7148acf
to
604b153
Compare
close in favour of #1397 |
Summary
During the heatmap legend fixes I've noticed that we have multiple places where some standard colors are allocated.
I've moved the
Color
type + some static colors (red, white, black, transparent) into thecommon/color.ts
file.This is not a complete refactoring but the first part of the initiative to cleanup the folders the typings.
Checklist
:xy
,:partition
):interactions
,:axis
)