test: replace mocks with snapshots #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
:test
rshen91
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
LGTM - This changing to snapshots makes sense to me especially in terms of the context of changing the data logic for the null values in tooltips PR. I think it should be manageable as a team for us to check any snapshot changes in a PR in future reviews (to make sure snapshots aren't being changed for bad reasons).
nickofthyme
approved these changes
Jun 28, 2021
packages/charts/src/chart_types/xy_chart/rendering/rendering.bands.test.ts
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in version 31.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use mocks for checking the equality of very big objects.
The PR refactored that code using snapshot instead: they provide the same functionality with less burden.
Details
This can simplify the refactoring in the following cases:
If we are testing an object structure, we probably can benefit directly from snapshots instead of manually writing the object.
The only caveat is to threat snapshots as code, checking them during the review as they where written inline in the test