fix(rendering): fix rendering values <= 0 on log scale #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0 values, we will hide them on the rendering of line and area charts. This fix also the defined area of the chart fix elastic#112, fix elastic#63
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 90.17% 91.09% +0.91%
==========================================
Files 31 31
Lines 1405 1460 +55
Branches 150 163 +13
==========================================
+ Hits 1267 1330 +63
+ Misses 125 116 -9
- Partials 13 14 +1
Continue to review full report at Codecov.
|
emmacunningham
approved these changes
Mar 22, 2019
src/lib/series/rendering.ts
Outdated
| @@ -263,10 +283,17 @@ export function renderArea( | |||
| areaGeometry: AreaGeometry; | |||
| indexedGeometries: Map<any, IndexedGeometry[]>; | |||
| } { | |||
| const isLogScale = yScale.type === ScaleType.Log; | |||
There was a problem hiding this comment.
Since this logic is repeated in a few places, could create a helper function isLogScale(type: ScaleType) to ensure consistency.
There was a problem hiding this comment.
resolved in 790d5f7
currently passing a Scale object instead of a type as it's done for the isContinuousScale or isOrdinalScale
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
19 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.4.2](elastic/elastic-charts@v3.4.1...v3.4.2) (2019-03-26) ### Bug Fixes * **rendering:** fix rendering values <= 0 on log scale ([opensearch-project#114](elastic/elastic-charts#114)) ([2b79877](elastic/elastic-charts@2b79877)), closes [opensearch-project#112](elastic/elastic-charts#112) [opensearch-project#63](elastic/elastic-charts#63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0
values, we will hide them on the rendering of line and area charts.
This fix also the defined area of a line/area chart: if the y value is null, the area/line is depicted with an empty space between the previous non null value and the following one.
fix #112, fix #63
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.