Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): add basic aria-label to canvas element #1084

Merged
merged 12 commits into from
Mar 25, 2021
Merged

feat(a11y): add basic aria-label to canvas element #1084

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6540bc8
feat: add static alternative text for xy_charts
rshen91 Mar 22, 2021
86875ab
test: update chart test
rshen91 Mar 22, 2021
5688159
refactor: adapt for smaller scope alt text
rshen91 Mar 22, 2021
65707a9
test: update unit tests
rshen91 Mar 23, 2021
25e0e2a
Merge remote-tracking branch 'upstream/master' into static-alt-text
rshen91 Mar 23, 2021
9a7b183
fix: fix chart api
rshen91 Mar 23, 2021
98d9ec2
refactor: remove screen reader component
rshen91 Mar 23, 2021
cc52c86
chore: update charts api
rshen91 Mar 23, 2021
0af139d
refactor: change a11y test to find name if present
rshen91 Mar 23, 2021
36a71d8
refactor: code review changes
rshen91 Mar 23, 2021
13d37f1
test: add eui upgrade story for color picker
rshen91 Mar 24, 2021
4ae9355
Merge remote-tracking branch 'upstream/master' into static-alt-text
rshen91 Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions .playground/playground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,31 @@

import React from 'react';

import { Example } from '../stories/small_multiples/7_sunbursts';
import { Chart, BarSeries, ScaleType, Settings } from '../src';

export class Playground extends React.Component {
render() {
return <Example />;
return (
<div className="story-chart story-root root">
<Chart size={[500, 200]}>
<Settings showLegend showLegendExtra />
<BarSeries
id="areas"
name="area"
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor={0}
yAccessors={[1]}
splitSeriesAccessors={[2]}
data={[
[0, 123, 'group0'],
[0, 123, 'group1'],
[0, 123, 'group2'],
[0, 123, 'group3'],
]}
/>
</Chart>
</div>
);
}
}
Loading