Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(partition): small multiples #1076

Merged
merged 31 commits into from
Mar 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b16daa0
feat: small multiples
monfera Mar 6, 2021
09e6d5a
test: mock update which is temporary
monfera Mar 11, 2021
dc5814e
test: mock update due to first part of margin fix ie text doesn't pro…
monfera Mar 11, 2021
bbbf7d8
fix: legend function post rebase fix
monfera Mar 11, 2021
62369dd
chore: old comment removal
monfera Mar 11, 2021
835b58a
fix: deactivate small multiples drilldown for now
monfera Mar 14, 2021
11a9ea3
feat: read inner breakdown direction from the spec
monfera Mar 14, 2021
f417693
feat: aspect ratio dependent inner panel zigzag
monfera Mar 14, 2021
55d4b2a
test: story mock update
monfera Mar 14, 2021
19881ad
fix: return nullShapeViewModel if there'd be nothing to return ie emp…
monfera Mar 14, 2021
473e50f
feat: fuller utilization of the space
monfera Mar 14, 2021
f1c0d89
test: knobs for layout
monfera Mar 15, 2021
7e8ce2b
feat: panel title
monfera Mar 15, 2021
e1e0e30
feat: separation of trees at multiplicative inner splot
monfera Mar 17, 2021
20348ae
feat: sort
monfera Mar 21, 2021
e240a93
chore: api update
monfera Mar 21, 2021
5693807
test: mock update
monfera Mar 21, 2021
fbdfcfc
test: changed mock for only sunburst
monfera Mar 21, 2021
a296549
feat: render panel title above the disk
monfera Mar 22, 2021
542f06f
feat: use inner margin from the small multiples spec
monfera Mar 22, 2021
dcf1e1a
chore: api doc improvs
monfera Mar 22, 2021
8987c66
fix: restored default inner pad
monfera Mar 22, 2021
6522be3
feat: using d3 scaleband padding conventions like xy
monfera Mar 22, 2021
883b840
feat: dedicate space for the panel title
monfera Mar 23, 2021
30e3241
chore: post rebase api gen
monfera Mar 23, 2021
5c1bbc2
refactor: new api convention for inner and outer padding
monfera Mar 23, 2021
b28d849
test: renamed test case
monfera Mar 23, 2021
5f2e3bb
chore: remove redundant check ht Marco
monfera Mar 23, 2021
cb12f05
fix: change the baseline for more robust vertical position ht Marco
monfera Mar 23, 2021
051c48b
Merge remote-tracking branch 'origin/master' into small-multiples-par…
monfera Mar 23, 2021
04062ad
chore: post-merge api update
monfera Mar 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ module.exports = {
: 0,
'import/namespace': process.env.NODE_ENV === 'production' ? 2 : 0,

/**
**************************************************************
* Rules that ensure sufficient freedom of expressing intent
**************************************************************
*/
'no-else-return': 'off',
'no-param-reassign': [1, { props: false }],
'@typescript-eslint/comma-spacing': 0,
'unicorn/no-nested-ternary': 0,
'@typescript-eslint/lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],

/**
*****************************************
* Rules to consider adding/fixing later
Expand All @@ -81,8 +92,6 @@ module.exports = {
'global-require': 1,
'import/no-dynamic-require': 1,
'no-shadow': 1,
'no-param-reassign': [1, { props: false }],
'@typescript-eslint/comma-spacing': 0,
'react/no-array-index-key': 1,
'react/prefer-stateless-function': 1,
'react/require-default-props': 'off',
Expand All @@ -92,7 +101,6 @@ module.exports = {
'jsx-a11y/click-events-have-key-events': 1,
'@typescript-eslint/member-ordering': 1,
eqeqeq: 1,
'unicorn/no-nested-ternary': 0,

/**
* Standard rules
Expand All @@ -107,7 +115,6 @@ module.exports = {
'no-bitwise': 0,
'no-void': 0,
yoda: 0,
'@typescript-eslint/lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
'no-restricted-globals': 0,
'no-case-declarations': 0,
'no-return-await': 0,
Expand Down Expand Up @@ -255,6 +262,7 @@ module.exports = {
'unicorn/no-null': 0,
'unicorn/no-fn-reference-in-iterator': 0,
'unicorn/prefer-query-selector': 0,
'unicorn/prefer-array-find': 0,
'unicorn/no-for-loop': 0,
'unicorn/no-reduce': 0,
'unicorn/no-useless-undefined': 0,
Expand Down
2 changes: 1 addition & 1 deletion .playground/playground.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import React from 'react';

import { Example } from '../stories/wordcloud/1_wordcloud';
import { Example } from '../stories/small_multiples/7_sunbursts';

export class Playground extends React.Component {
render() {
Expand Down
Loading