Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(axis): formatting different for label vs tooltip and legend #750

Merged
merged 3 commits into from
Jul 15, 2020
Merged

feat(axis): formatting different for label vs tooltip and legend #750

merged 3 commits into from
Jul 15, 2020

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Jul 13, 2020 •
edited
Loading

Summary

closes #713

Add label formatter for different formats between axis tick labels and tooltip/legend

Screen Recording 2020-07-13 at 10 31 AM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added enhancement New feature or request :axis Axis related issue labels Jul 13, 2020
@nickofthyme nickofthyme requested a review from markov00 July 13, 2020 15:54
@nickofthyme nickofthyme marked this pull request as ready for review July 13, 2020 23:10
markov00
markov00 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM until we split Data, Formatters Axis and Tooltip in their own component

@nickofthyme nickofthyme merged commit daff503 into elastic:master Jul 15, 2020
markov00 pushed a commit that referenced this pull request Jul 17, 2020
@semantic-release-bot
chore(release): 19.9.0 [skip ci]
ce4349f 
# [19.9.0](v19.8.1...v19.9.0) (2020-07-17)

### Features

* **axis:** formatting different for label vs tooltip and legend ([#750](#750)) ([daff503](daff503))
* **legend:** add legend item actions and margins ([#749](#749)) ([8136dca](8136dca)), closes [#717](#717)
@markov00
Copy link
Member

🎉 This PR is included in version 19.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 17, 2020
@nickofthyme nickofthyme deleted the label-format branch January 25, 2021 15:13
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 19.9.0 [skip ci]
e312c56 
# [19.9.0](elastic/elastic-charts@v19.8.1...v19.9.0) (2020-07-17)

### Features

* **axis:** formatting different for label vs tooltip and legend ([#750](elastic/elastic-charts#750)) ([027a772](elastic/elastic-charts@027a772))
* **legend:** add legend item actions and margins ([opensearch-project#749](elastic/elastic-charts#749)) ([75ce7b0](elastic/elastic-charts@75ce7b0)), closes [opensearch-project#717](elastic/elastic-charts#717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
:axis Axis related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tickFormatter for legend, tooltip and axis
2 participants
@nickofthyme @markov00