Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend actions #717

Closed
nickofthyme opened this issue Jun 17, 2020 · 1 comment · Fixed by #749
Closed

Legend actions #717

nickofthyme opened this issue Jun 17, 2020 · 1 comment · Fixed by #749
Assignees
@nickofthyme
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Jun 17, 2020 •
edited
Loading

Legend actions

Adds the option for legend actions to the legend item. Preserves the toggle ability of the series and the color picker option for clicking the color dot itself.

Hover state

Adds blue highlight and action icon or slot to render react component.
image

Click/focus state

Adds blue highlight to focused icon

image

The context menu will be a consumers implementation

Design for small width legends

image
@nickofthyme nickofthyme added enhancement New feature or request :legend Legend related issue labels Jun 17, 2020
@markov00 markov00 mentioned this issue Jun 17, 2020
Closed
27 tasks
@nickofthyme nickofthyme changed the title Disable legend toggle Disable legend series toggle Jun 17, 2020
@nickofthyme nickofthyme mentioned this issue Jun 17, 2020
Closed
23 tasks
@nickofthyme nickofthyme changed the title Disable legend series toggle Legend actions Jun 18, 2020
@nickofthyme nickofthyme self-assigned this Jun 18, 2020
@nickofthyme nickofthyme mentioned this issue Jul 13, 2020
Merged
4 tasks
nickofthyme added a commit that referenced this issue Jul 17, 2020
@nickofthyme
feat(legend): add legend item actions and margins (#749)
8136dca 
- adds legend actions at the end of the legend items
- Adds margins on inner and outer sides of legend

closes #717
markov00 pushed a commit that referenced this issue Jul 17, 2020
@semantic-release-bot
chore(release): 19.9.0 [skip ci]
ce4349f 
# [19.9.0](v19.8.1...v19.9.0) (2020-07-17)

### Features

* **axis:** formatting different for label vs tooltip and legend ([#750](#750)) ([daff503](daff503))
* **legend:** add legend item actions and margins ([#749](#749)) ([8136dca](8136dca)), closes [#717](#717)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 19.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 17, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.9.0 [skip ci]
e312c56 
# [19.9.0](elastic/elastic-charts@v19.8.1...v19.9.0) (2020-07-17)

### Features

* **axis:** formatting different for label vs tooltip and legend ([#750](elastic/elastic-charts#750)) ([027a772](elastic/elastic-charts@027a772))
* **legend:** add legend item actions and margins ([opensearch-project#749](elastic/elastic-charts#749)) ([75ce7b0](elastic/elastic-charts@75ce7b0)), closes [opensearch-project#717](elastic/elastic-charts#717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(legend): add legend item actions nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme