-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(axis): rotated label positioning #709
fix(axis): rotated label positioning #709
Conversation
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 74.80% 75.16% +0.35%
==========================================
Files 264 280 +16
Lines 8514 8842 +328
Branches 1709 1759 +50
==========================================
+ Hits 6369 6646 +277
- Misses 2093 2138 +45
- Partials 52 58 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tested locally this fixes the issue
## [19.5.1](v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([#704](#704)) ([ed49bbb](ed49bbb)), closes [#678](#678) * **axis:** rotated label positioning ([#709](#709)) ([2e26430](2e26430)), closes [#673](#673) * **tooltip:** popper scroll issue ([#712](#712)) ([0c97c67](0c97c67))
🎉 This PR is included in version 19.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [19.5.1](elastic/elastic-charts@v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([opensearch-project#704](elastic/elastic-charts#704)) ([fe8e322](elastic/elastic-charts@fe8e322)), closes [opensearch-project#678](elastic/elastic-charts#678) * **axis:** rotated label positioning ([opensearch-project#709](elastic/elastic-charts#709)) ([7146799](elastic/elastic-charts@7146799)), closes [opensearch-project#673](elastic/elastic-charts#673) * **tooltip:** popper scroll issue ([opensearch-project#712](elastic/elastic-charts#712)) ([54ed46b](elastic/elastic-charts@54ed46b))
Summary
Fixes #673
Used rotated
maxLabelBboxWidth
to position vertical axis instead ofmaxLabelTextWidth
.Checklist