Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right Axis rotation pushes label off chart #673

Closed
nickofthyme opened this issue May 12, 2020 · 1 comment · Fixed by #709 or elastic/kibana#69126
Closed

Right Axis rotation pushes label off chart #673

nickofthyme opened this issue May 12, 2020 · 1 comment · Fixed by #709 or elastic/kibana#69126
Assignees
@nickofthyme
Labels
:axis Axis related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
Using position right Axis with a rotation -90 and others, the Label is pushed off the chart.

<Axis
  position={Position.Right}
  tickLabelRotation={-90}
  {/* ... */}
/>

To Reproduce
https://codesandbox.io/s/dawn-dew-xuv6i

Expected behaviour
Label should be visible

Screenshots
Image 2020-05-12 at 9 30 51 AM

Version (please complete the following information):

  • OS: mac
  • Browser: all
  • Elastic Charts: 19.0.1
@nickofthyme nickofthyme added bug Something isn't working :axis Axis related issue labels May 12, 2020
@nickofthyme nickofthyme changed the title Right Axis rotation pushes Label off chart Right Axis rotation pushes label off chart May 12, 2020
@markov00 markov00 added the :xy Bar/Line/Area chart related label May 29, 2020
@markov00 markov00 mentioned this issue May 29, 2020
Closed
27 tasks
@nickofthyme nickofthyme mentioned this issue Jun 15, 2020
Merged
1 task
@nickofthyme nickofthyme self-assigned this Jun 15, 2020
nickofthyme added a commit that referenced this issue Jun 15, 2020
@nickofthyme
fix(axis): rotated label positioning (#709)
2e26430 
Fix title positioning when using rotated tick labels

fixes #673
markov00 pushed a commit that referenced this issue Jun 16, 2020
@semantic-release-bot
chore(release): 19.5.1 [skip ci]
c540c8a 
## [19.5.1](v19.5.0...v19.5.1) (2020-06-16)

### Bug Fixes

* graceful scale fallbacks and warnings ([#704](#704)) ([ed49bbb](ed49bbb)), closes [#678](#678)
* **axis:** rotated label positioning ([#709](#709)) ([2e26430](2e26430)), closes [#673](#673)
* **tooltip:** popper scroll issue ([#712](#712)) ([0c97c67](0c97c67))
@markov00
Copy link
Member

🎉 This issue has been resolved in version 19.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 16, 2020
@markov00 markov00 mentioned this issue Jun 17, 2020
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.5.1 [skip ci]
8ffdcd3 
## [19.5.1](elastic/elastic-charts@v19.5.0...v19.5.1) (2020-06-16)

### Bug Fixes

* graceful scale fallbacks and warnings ([opensearch-project#704](elastic/elastic-charts#704)) ([fe8e322](elastic/elastic-charts@fe8e322)), closes [opensearch-project#678](elastic/elastic-charts#678)
* **axis:** rotated label positioning ([opensearch-project#709](elastic/elastic-charts#709)) ([7146799](elastic/elastic-charts@7146799)), closes [opensearch-project#673](elastic/elastic-charts#673)
* **tooltip:** popper scroll issue ([opensearch-project#712](elastic/elastic-charts#712)) ([54ed46b](elastic/elastic-charts@54ed46b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
:axis Axis related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
2 participants
@markov00 @nickofthyme