-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: graceful scale fallbacks and warnings #704
fix: graceful scale fallbacks and warnings #704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 74.80% 75.14% +0.33%
==========================================
Files 264 280 +16
Lines 8514 8846 +332
Branches 1709 1760 +51
==========================================
+ Hits 6369 6647 +278
- Misses 2093 2141 +48
- Partials 52 58 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM
## [19.5.1](v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([#704](#704)) ([ed49bbb](ed49bbb)), closes [#678](#678) * **axis:** rotated label positioning ([#709](#709)) ([2e26430](2e26430)), closes [#673](#673) * **tooltip:** popper scroll issue ([#712](#712)) ([0c97c67](0c97c67))
🎉 This PR is included in version 19.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [19.5.1](elastic/elastic-charts@v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([opensearch-project#704](elastic/elastic-charts#704)) ([fe8e322](elastic/elastic-charts@fe8e322)), closes [opensearch-project#678](elastic/elastic-charts#678) * **axis:** rotated label positioning ([opensearch-project#709](elastic/elastic-charts#709)) ([7146799](elastic/elastic-charts@7146799)), closes [opensearch-project#673](elastic/elastic-charts#673) * **tooltip:** popper scroll issue ([opensearch-project#712](elastic/elastic-charts#712)) ([54ed46b](elastic/elastic-charts@54ed46b))
Summary
fix #678
Adds x scale fallback to
ScaleType.Ordinal
when there is a non-numeric value found in the dataset. This includes a warning for y values that are not numeric values. The current functionality is to error.Each X value in a linear x scale needs be be a number. Using ordinal x scale as fallback.
Adds warning for y values that are not parable into a numeric value.
Example
String value
'a'
among numeric values, converts scale fromlinear
toordinal
Checklist
Delete any items that are not applicable to this PR.
src/index.ts
(and stories only import from../src
except for test data & storybook)