Treemap should also observe the fillLabel.padding setting

[wylieconlon]

Thanks @monfera for merging the update to add grooved text! I'm trying it out, and found what looks like a bug. I see in the "groove label" storybook example the commented out settings for fillLabel.padding, but when I uncomment the settings nothing changes. This is also happening in my Lens configuration:

[monfera]

@wylieconlon correct, see description. As it's a different layouting it hasn't yet been added back, the plan is to reinstate it in a next PR now that #658 is merged - it's very motivating to see it with this small typeface where it's most felt, thanks!

Btw. it looks good with these EUI colors! Maybe it'd be better for group separation and group label readability to not color the groups themselves (it's unrelated to your note so I don't view it as a design decision). The grooves are also height constrained, sandwiching the group label text, which therefore have inherent visual noise above and below, so using color there has a worse effect than coloring the leaf nodes themselves. The group delineation also varies with lightness, Men's Shoes is better separated than Women's Accessories

[monfera]

Minor note, the padding was never in effect for the treemap but it wasn't obvious as text was centered verticlaly and horizontally, so I'm removing the bug label. Also, the padding needs to be more sophisticated - per direction, eg. paddingLeft can be important for groove labels but uniform all around padding would remove too much from the vertical space

[markov00]

🎉 This issue has been resolved in version 19.2.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀