-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crosshair): hide horizontal line when the pointer is outside chart #484
fix(crosshair): hide horizontal line when the pointer is outside chart #484
Conversation
This commit fix the visibility of the crosshair horizontal line, hiding it when the pointer projected position is outside the chart area. fix elastic#483
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=========================================
- Coverage 83.77% 83.7% -0.08%
=========================================
Files 158 169 +11
Lines 4703 4853 +150
Branches 952 966 +14
=========================================
+ Hits 3940 4062 +122
- Misses 748 775 +27
- Partials 15 16 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
🎉 This PR is included in version 15.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [15.0.2](elastic/elastic-charts@v15.0.1...v15.0.2) (2019-12-05) ### Bug Fixes * **crosshair:** hide horizontal line when the pointer is outside chart ([opensearch-project#484](elastic/elastic-charts#484)) ([bb52d35](elastic/elastic-charts@bb52d35)), closes [opensearch-project#483](elastic/elastic-charts#483)
Summary
This commit fix the visibility of the crosshair horizontal line, hiding
it when the pointer projected position is outside the chart area.
fix #483
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)![ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials