Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosshair line visible when pointer is outside chart #483

Closed
markov00 opened this issue Dec 5, 2019 · 1 comment · Fixed by #484 or elastic/kibana#52619
Closed

Crosshair line visible when pointer is outside chart #483

markov00 opened this issue Dec 5, 2019 · 1 comment · Fixed by #484 or elastic/kibana#52619
Assignees
@markov00
Labels
bug Something isn't working regression released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Dec 5, 2019

Describe the bug
When using TooltipType.Crosshair the horizontal line remain visible also when the pointer is outside the chart area.

To Reproduce
Steps to reproduce the behavior:

  1. Configure a simple chart with the following settings:
<Chart>
  <Settings tooltip={TooltipType.Crosshairs} />
  <BarSeries
    id={'bar'}
    xScaleType={ScaleType.Time}
    yScaleType={ScaleType.Linear}
    xAccessor={0}
    yAccessors={[1]}
    data={KIBANA_METRICS.metrics.kibana_os_load[0].data}
  />
</Chart>
  1. Move the mouse over the chart to see the crosshair line
  2. Move the mouse outside the chart, the crosshair line remain visible on the top of the chart

Expected behavior
If the pointer is outside the chart, than the crosshair line should be hidden

Screenshots
Screenshot 2019-12-05 at 12 49 42

Version (please complete the following information):

  • Elastic Charts: 15.x
@markov00 markov00 added bug Something isn't working regression labels Dec 5, 2019
@markov00 markov00 self-assigned this Dec 5, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Dec 5, 2019
@markov00
fix(crosshair): hide horizontal line when the pointer is outside chart
7a7ca09 
This commit fix the visibility of the crosshair horizontal line, hiding
it when the pointer projected position is outside the chart area.

fix elastic#483
@markov00 markov00 mentioned this issue Dec 5, 2019
Merged
2 tasks
markov00 added a commit that referenced this issue Dec 5, 2019
@markov00
fix(crosshair): hide horizontal line when the pointer is outside chart (
654d929 
#484)

This commit fix the visibility of the crosshair horizontal line, hiding
it when the pointer projected position is outside the chart area.

fix #483
markov00 pushed a commit that referenced this issue Dec 5, 2019
@semantic-release-bot
chore(release): 15.0.2 [skip ci]
77c4a74 
## [15.0.2](v15.0.1...v15.0.2) (2019-12-05)

### Bug Fixes

* **crosshair:** hide horizontal line when the pointer is outside chart ([#484](#484)) ([654d929](654d929)), closes [#483](#483)
@markov00
Copy link
Member Author

markov00 commented Dec 5, 2019

🎉 This issue has been resolved in version 15.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 5, 2019
@markov00 markov00 mentioned this issue Dec 10, 2019
Merged
4 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 15.0.2 [skip ci]
d2b63f7 
## [15.0.2](elastic/elastic-charts@v15.0.1...v15.0.2) (2019-12-05)

### Bug Fixes

* **crosshair:** hide horizontal line when the pointer is outside chart ([opensearch-project#484](elastic/elastic-charts#484)) ([bb52d35](elastic/elastic-charts@bb52d35)), closes [opensearch-project#483](elastic/elastic-charts#483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working regression released Issue released publicly
Projects
None yet
Milestone
No milestone
1 participant
@markov00