Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): disable fade of other charts when hiding an item #446

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

majagrubic
Copy link

@majagrubic majagrubic commented Oct 31, 2019

Summary

Taking over from:
#321

Fixes in this PR:

  • When hovering on a legend item that is currently hidden, don't fade the other series
  • Fade in all the series right after a series in the legend is clicked

legend-toggle

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

[ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
[ ] Proper documentation or storybook story was added for features that require explanation or tutorials

@majagrubic majagrubic requested a review from markov00 October 31, 2019 12:41
@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files          41       41              
  Lines        2927     2937      +10     
  Branches      710      713       +3     
==========================================
+ Hits         2865     2875      +10     
  Misses         55       55              
  Partials        7        7
Impacted Files Coverage Δ
src/chart_types/xy_chart/store/chart_state.ts 97.51% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4339a...4b6b342. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally and works fine

@majagrubic majagrubic merged commit ff4e097 into master Oct 31, 2019
@majagrubic majagrubic deleted the maja/mouseover-deselected-series branch October 31, 2019 15:23
markov00 pushed a commit that referenced this pull request Oct 31, 2019
## [13.5.10](v13.5.9...v13.5.10) (2019-10-31)

### Bug Fixes

* **legend:** disable fade of other charts when hiding an item ([#446](#446)) ([ff4e097](ff4e097))
@markov00
Copy link
Member

🎉 This PR is included in version 13.5.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 31, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
## [13.5.10](elastic/elastic-charts@v13.5.9...v13.5.10) (2019-10-31)

### Bug Fixes

* **legend:** disable fade of other charts when hiding an item ([opensearch-project#446](elastic/elastic-charts#446)) ([fc680cf](elastic/elastic-charts@fc680cf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants