Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legend sizing issue with no initial legend #441

Merged
merged 6 commits into from
Oct 25, 2019

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Oct 24, 2019

Summary

Prevent setting legend width when element width is 0.

Fix 0 width legends in lens

Before

Screen Recording 2019-10-24 at 03 33 PM

After

Screen Recording 2019-10-24 at 03 22 PM

Trigger legend to resize (grow/shrink) when legend item count changes

Dynamic charts such as TSBV create dynamic legend content which leaves legends squished when resize is only on initialization.

Screen Recording 2019-10-24 at 04 07 PM

fixes #367

Adds build:watch script to run elastic-charts in watch mode when symlinked to kibana.

Checklist

Verified in Chrome, Firefox, safari and IE. All look good, though IE seems to not be fully supported rn.

image

  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme nickofthyme requested a review from markov00 October 24, 2019 20:36
@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          41       41           
  Lines        2927     2927           
  Branches      710      692   -18     
=======================================
  Hits         2865     2865           
  Misses         55       55           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c5d27...837d81f. Read the comment docs.

@nickofthyme nickofthyme merged commit 64b9f83 into elastic:master Oct 25, 2019
@nickofthyme nickofthyme deleted the fix/legend-sizing branch October 25, 2019 16:56
markov00 pushed a commit that referenced this pull request Oct 25, 2019
## [13.5.9](v13.5.8...v13.5.9) (2019-10-25)

### Bug Fixes

* initial legend sizing issue ([#441](#441)) ([64b9f83](64b9f83)), closes [#367](#367)
@markov00
Copy link
Member

🎉 This PR is included in version 13.5.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 25, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend should resize when series titles change
3 participants