Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations should be able to handle scenarios where the min value matches the max value of the dataset #438

Closed
Kerry350 opened this issue Oct 24, 2019 · 1 comment · Fixed by #842
Closed

Annotations should be able to handle scenarios where the min value matches the max value of the dataset #438

Kerry350 opened this issue Oct 24, 2019 · 1 comment · Fixed by #842
Assignees
@rshen91
Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working :chart Chart element related issue released Issue released publicly :xy Bar/Line/Area chart related

Comments

@Kerry350
Copy link

Kerry350 commented Oct 24, 2019 •
edited
Loading

There is an original explanation of this problem with data examples here, and a followup comment on the problem here.

The overall issue is that annotations should still be rendered if their values match the max value of the dataset, and that max value is 0.
@markov00 markov00 added :annotation Annotation (line, rect, text) related issue :chart Chart element related issue bug Something isn't working labels Oct 24, 2019
@markov00 markov00 added the :xy Bar/Line/Area chart related label Mar 26, 2020
@markov00 markov00 mentioned this issue May 29, 2020
Open
5 tasks
@rshen91 rshen91 self-assigned this Sep 29, 2020
@rshen91 rshen91 mentioned this issue Oct 1, 2020
Merged
2 tasks
rshen91 added a commit that referenced this issue Oct 12, 2020
@rshen91
fix(annotation): annotation rendering with no yDomain or groupId (#842)
f173b49 
fixes #438, #798
Co-authored-by: nickofthyme <[email protected]>
markov00 pushed a commit that referenced this issue Oct 19, 2020
@semantic-release-bot
chore(release): 24.0.0 [skip ci]
eda6889 
# [24.0.0](v23.2.1...v24.0.0) (2020-10-19)

### Bug Fixes

* **annotation:** annotation rendering with no yDomain or groupId ([#842](#842)) ([f173b49](f173b49)), closes [#438](#438) [#798](#798)

### Features

* **bar_chart:** add Alignment offset to value labels ([#784](#784)) ([363aeb4](363aeb4))
* **bar_chart:** add shadow prop for value labels ([#785](#785)) ([9b29392](9b29392))
* **bar_chart:** scaled font size for value labels ([#789](#789)) ([3bdd1ee](3bdd1ee)), closes [#788](#788)
* **heatmap:** allow fixed right margin ([#873](#873)) ([16cf73c](16cf73c))

### BREAKING CHANGES

* **bar_chart:** The `DisplayValueStyle` `fontSize` property can now express an upper and lower bound as size, used for the automatic scaling.
* **bar_chart:** The `DisplayValueStyle` `fill` property can now express a border color and width, or let the library pick the best match based on contrast using the textInvertible parameter.
@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 19, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.0.0 [skip ci]
3b372d8 
# [24.0.0](elastic/elastic-charts@v23.2.1...v24.0.0) (2020-10-19)

### Bug Fixes

* **annotation:** annotation rendering with no yDomain or groupId ([opensearch-project#842](elastic/elastic-charts#842)) ([6bad0d7](elastic/elastic-charts@6bad0d7)), closes [opensearch-project#438](elastic/elastic-charts#438) [opensearch-project#798](elastic/elastic-charts#798)

### Features

* **bar_chart:** add Alignment offset to value labels ([opensearch-project#784](elastic/elastic-charts#784)) ([106d924](elastic/elastic-charts@106d924))
* **bar_chart:** add shadow prop for value labels ([opensearch-project#785](elastic/elastic-charts#785)) ([de95b44](elastic/elastic-charts@de95b44))
* **bar_chart:** scaled font size for value labels ([opensearch-project#789](elastic/elastic-charts#789)) ([8b74a9d](elastic/elastic-charts@8b74a9d)), closes [opensearch-project#788](elastic/elastic-charts#788)
* **heatmap:** allow fixed right margin ([opensearch-project#873](elastic/elastic-charts#873)) ([dd34574](elastic/elastic-charts@dd34574))

### BREAKING CHANGES

* **bar_chart:** The `DisplayValueStyle` `fontSize` property can now express an upper and lower bound as size, used for the automatic scaling.
* **bar_chart:** The `DisplayValueStyle` `fill` property can now express a border color and width, or let the library pick the best match based on contrast using the textInvertible parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working :chart Chart element related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(annotation): annotation rendering with no yDomain or groupId elastic/elastic-charts
3 participants
@Kerry350 @markov00 @rshen91