Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix axis labels for time series overlapping into each other on smaller window sizes #42

Closed
emmacunningham opened this issue Feb 5, 2019 · 1 comment · Fixed by #45
Closed

Fix axis labels for time series overlapping into each other on smaller window sizes #42

emmacunningham opened this issue Feb 5, 2019 · 1 comment · Fixed by #45
Assignees
@emmacunningham
Labels
bug Something isn't working released Issue released publicly

Comments

@emmacunningham
Copy link
Contributor

time_series_labels
@emmacunningham emmacunningham self-assigned this Feb 5, 2019
@emmacunningham emmacunningham added the bug Something isn't working label Feb 6, 2019
@emmacunningham emmacunningham mentioned this issue Feb 6, 2019
Merged
emmacunningham added a commit to emmacunningham/elastic-charts that referenced this issue Feb 7, 2019
@emmacunningham
fix(axis labels): offset previous space correctly
290fdf0 
This fixes the overlapping labels issue that was surfacing in time series labels where the first and
second labels would overlap even when showOverlappingTicks/Labels was false.  The issue is that the
previousOccupiedSpace variable which was being used to determine if a tick/label should be included
in the set of visible ticks/labels was not being updated correctly for the first tick, causing the
next tick to render (even when it should have been hidden).  This commit fixes that value update as
well as simplifies the initialization of the variable to make the logic flow a bit easier to follow.

fixes elastic#42
emmacunningham added a commit that referenced this issue Feb 7, 2019
@emmacunningham
fix(axis labels): offset previous space correctly (#45)
ff2a47a 
* fix(axis labels): offset previous space correctly

This fixes the overlapping labels issue that was surfacing in time series labels where the first and
second labels would overlap even when showOverlappingTicks/Labels was false.  The issue is that the previousOccupiedSpace variable which was being used to determine if a tick/label should be included in the set of visible ticks/labels was not being updated correctly for the first tick, causing the next tick to render (even when it should have been hidden).  This commit fixes that value update as well as simplifies the initialization of the variable to make the logic flow a bit easier to follow.

fixes #42

* docs(axis/time series): add knobs to time series story

* build: move newtype-ts to dependencies (from devDependencies)
markov00 pushed a commit that referenced this issue Feb 7, 2019
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
7ed890c 
## [1.0.1](v1.0.0...v1.0.1) (2019-02-07)

### Bug Fixes

* **axis labels:** offset previous space correctly ([#45](#45)) ([ff2a47a](ff2a47a)), closes [#42](#42)
@markov00
Copy link
Member

markov00 commented Feb 7, 2019

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 7, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
a6a608e 
## [1.0.1](elastic/elastic-charts@v1.0.0...v1.0.1) (2019-02-07)

### Bug Fixes

* **axis labels:** offset previous space correctly ([opensearch-project#45](elastic/elastic-charts#45)) ([c28e0d7](elastic/elastic-charts@c28e0d7)), closes [opensearch-project#42](elastic/elastic-charts#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmacunningham emmacunningham

Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(axis labels): offset previous space correctly emmacunningham/elastic-charts
2 participants
@emmacunningham @markov00