Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chart rotation animations #41

Closed
emmacunningham opened this issue Feb 5, 2019 · 2 comments
Closed

Fix chart rotation animations #41

emmacunningham opened this issue Feb 5, 2019 · 2 comments
Labels
bug Something isn't working :chart Chart element related issue

Comments

@emmacunningham
Copy link
Contributor

When rotating the chart, the left/right edges of the chart animation are bounded to the dimensions of the chart container, but not for the top/right edges so that the chart will appear to animate from outside of the container.

chart_rotation_animation
@emmacunningham emmacunningham added the bug Something isn't working label Feb 5, 2019
@markov00
Copy link
Member

markov00 commented Feb 6, 2019

I've 3 ideas here:

  • we don't fix it directly: since we have a clipping rectangle, the final user will never see elements outside the clipping rectangle.
  • we can fix the animation
  • we can disable animation on rotation (rotation is a setting and we don't need to animate that change)

@markov00 markov00 added the :chart Chart element related issue label Feb 28, 2019
@markov00 markov00 mentioned this issue Apr 10, 2019
Closed
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation
2898ff4 
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix elastic#161
@markov00 markov00 mentioned this issue Apr 11, 2019
Merged
1 task
markov00 added a commit that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation (#164)
80b3231 
Disable animations for all charts until we fix #89 and #41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix #161
markov00 pushed a commit that referenced this issue Apr 11, 2019
@semantic-release-bot
chore(release): 3.10.1 [skip ci]
3d0a897 
## [3.10.1](v3.10.0...v3.10.1) (2019-04-11)

### Bug Fixes

* temporary disable animation ([#164](#164)) ([80b3231](80b3231)), closes [#89](#89) [#41](#41) [#161](#161)
* temporary disable animation ([#164](#164)) ([c53c8a6](c53c8a6)), closes [#89](#89) [#41](#41) [#161](#161)
emmacunningham pushed a commit to emmacunningham/elastic-charts that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation (elastic#164)
c53c8a6 
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix elastic#161
@markov00
Copy link
Member

closing for now as animation is not a priority at the moment and the underlying architecture is has changed

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.10.1 [skip ci]
6b3f056 
## [3.10.1](elastic/elastic-charts@v3.10.0...v3.10.1) (2019-04-11)

### Bug Fixes

* temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([0d12878](elastic/elastic-charts@0d12878)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161)
* temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([76ab583](elastic/elastic-charts@76ab583)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :chart Chart element related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emmacunningham @markov00