Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(annotations): markers shown in empty chart #358

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix(annotations): markers shown in empty chart #358

merged 1 commit into from
Aug 28, 2019

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 28, 2019 •
edited
Loading

Summary

Fix markers from showing in the empty chart state

closes #357

Screen Recording 2019-08-27 at 09 15 PM

Checklist

@codecov-io
Copy link

codecov-io commented Aug 28, 2019 •
edited
Loading

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          38       38           
  Lines        2772     2772           
  Branches      654      654           
=======================================
  Hits         2724     2724           
  Misses         44       44           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259fd14...99c0601. Read the comment docs.

@nickofthyme nickofthyme merged commit 8dbf54e into elastic:master Aug 28, 2019
@nickofthyme nickofthyme deleted the fix/annotation-markers branch August 28, 2019 02:30
markov00 pushed a commit that referenced this pull request Aug 28, 2019
@semantic-release-bot
chore(release): 11.1.1 [skip ci]
ae1d499 
## [11.1.1](v11.1.0...v11.1.1) (2019-08-28)

### Bug Fixes

* **annotations:** markers shown in empty chart ([#358](#358)) ([8dbf54e](8dbf54e)), closes [#357](#357)
@markov00
Copy link
Member

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 28, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 11.1.1 [skip ci]
1707ad1 
## [11.1.1](elastic/elastic-charts@v11.1.0...v11.1.1) (2019-08-28)

### Bug Fixes

* **annotations:** markers shown in empty chart ([opensearch-project#358](elastic/elastic-charts#358)) ([09c970f](elastic/elastic-charts@09c970f)), closes [opensearch-project#357](elastic/elastic-charts#357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation icons visible in empty chart
3 participants
@nickofthyme @codecov-io @markov00