fix(annotations): markers shown in empty chart (#358)

closes #357
elastic · Aug 28, 2019 · 8dbf54e · 8dbf54e
1 parent 259fd14
commit 8dbf54e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/components/annotation_tooltips.tsx b/src/components/annotation_tooltips.tsx
@@ -104,6 +104,12 @@ class AnnotationTooltipComponent extends React.Component<AnnotationTooltipProps>
   }
 
   render() {
+    const { chartStore } = this.props;
+
+    if (chartStore!.isChartEmpty.get()) {
+      return null;
+    }
+
     return (
       <React.Fragment>
         {this.renderAnnotationMarkers()}

diff --git a/stories/annotations.tsx b/stories/annotations.tsx
@@ -73,7 +73,7 @@ storiesOf('Annotations', module)
 
     return (
       <Chart className={'story-chart'}>
-        <Settings debug={boolean('debug', false)} rotation={chartRotation} />
+        <Settings showLegend debug={boolean('debug', false)} rotation={chartRotation} />
         <LineAnnotation
           annotationId={getAnnotationId('anno_1')}
           domainType={AnnotationDomainTypes.XDomain}