Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty chart state hover #337

Closed
nickofthyme opened this issue Aug 21, 2019 · 1 comment · Fixed by #338
Closed

Empty chart state hover #337

nickofthyme opened this issue Aug 21, 2019 · 1 comment · Fixed by #338
Assignees
@nickofthyme
Labels
bug Something isn't working released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Aug 21, 2019 •
edited
Loading

Describe the bug

Disabling all series shows the empty state with hoverable element.

Steps to reproduce

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/legend--bottom
  2. Click to toggle all but one series off
  3. Hover over one of the bars
  4. Toggle the final series off so that the chart is empty
  5. Hover over the empty chart area

Notice the last hovered band is toggled on and off.

Screenshot

Screen Recording 2019-08-21 at 08 10 PM
@nickofthyme nickofthyme added the bug Something isn't working label Aug 21, 2019
@nickofthyme nickofthyme self-assigned this Aug 21, 2019
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Aug 22, 2019
@nickofthyme
fix(crosshair): hide band when chart is empty
f6d4f7f 
Hide chart band when chart is empty

fix elastic#337
@nickofthyme nickofthyme mentioned this issue Aug 22, 2019
Merged
2 tasks
nickofthyme added a commit that referenced this issue Aug 22, 2019
@nickofthyme
fix(crosshair): disable band when chart is empty (#338)
3bd0c43 
Disable chart hover band when chart is empty

fix #337
markov00 pushed a commit that referenced this issue Aug 22, 2019
@semantic-release-bot
chore(release): 10.1.1 [skip ci]
b4982c9 
## [10.1.1](v10.1.0...v10.1.1) (2019-08-22)

### Bug Fixes

* **crosshair:** disable band when chart is empty ([#338](#338)) ([3bd0c43](3bd0c43)), closes [#337](#337)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 22, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 10.1.1 [skip ci]
f5cecd8 
## [10.1.1](elastic/elastic-charts@v10.1.0...v10.1.1) (2019-08-22)

### Bug Fixes

* **crosshair:** disable band when chart is empty ([opensearch-project#338](elastic/elastic-charts#338)) ([b67ec06](elastic/elastic-charts@b67ec06)), closes [opensearch-project#337](elastic/elastic-charts#337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(crosshair): hide band when chart is empty nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme