Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default theme #336

Merged
merged 1 commit into from
Aug 21, 2019
Merged

fix: default theme #336

merged 1 commit into from
Aug 21, 2019

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 21, 2019 •
edited
Loading

Summary

Revert default theme changes in chart_state

image

Checklist

@nickofthyme nickofthyme requested a review from markov00 August 21, 2019 20:38
markov00
markov00 approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally

@codecov-io
Copy link

codecov-io commented Aug 21, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   98.51%   98.51%   +<.01%     
==========================================
  Files          38       38              
  Lines        2689     2691       +2     
  Branches      635      621      -14     
==========================================
+ Hits         2649     2651       +2     
  Misses         37       37              
  Partials        3        3
Impacted Files Coverage Δ
src/chart_types/xy_chart/store/chart_state.ts 97.1% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b756116...1a29450. Read the comment docs.

@nickofthyme nickofthyme merged commit 2edadb2 into elastic:master Aug 21, 2019
markov00 pushed a commit that referenced this pull request Aug 21, 2019
@semantic-release-bot
chore(release): 10.0.1 [skip ci]
e94dab9 
## [10.0.1](v10.0.0...v10.0.1) (2019-08-21)

### Bug Fixes

* default theme ([#336](#336)) ([2edadb2](2edadb2))
@markov00
Copy link
Member

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 21, 2019
@nickofthyme nickofthyme deleted the fix/default-theme branch August 26, 2019 20:02
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 10.0.1 [skip ci]
ba1f7f7 
## [10.0.1](elastic/elastic-charts@v10.0.0...v10.0.1) (2019-08-21)

### Bug Fixes

* default theme ([opensearch-project#336](elastic/elastic-charts#336)) ([a2e1c36](elastic/elastic-charts@a2e1c36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickofthyme @codecov-io @markov00