Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Pull external links from config file #336

Open
kavilla opened this issue May 7, 2021 · 0 comments
Open

Proposal: Pull external links from config file #336

kavilla opened this issue May 7, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Community development is encouraged proposal

Comments

@kavilla
Copy link
Member

kavilla commented May 7, 2021

Is your feature request related to a problem? Please describe.

Most of the external links within the code seem to be hardcoded within TypeScript (ie https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/public/doc_links/doc_links_service.ts).

Describe the solution you'd like

Config file where the project pulls the links from and the TypeScript files reference.

Describe alternatives you've considered

n/a

Additional context
We broke most links while renaming, now we have to go through most of the links for different TypeScript files and fix it. By using a config we can handle localization and provide customers links that are localized to the customer and also we can allow people who fork to update the links to their own locations.

@kavilla kavilla added the enhancement New feature or request label May 7, 2021
@tmarkley tmarkley changed the title Pull external links from config file Proposal: Pull external links from config file Jul 20, 2021
@tmarkley tmarkley added the help wanted Community development is encouraged label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Community development is encouraged proposal
Projects
None yet
Development

No branches or pull requests

2 participants