Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosshairs hover tooltip & highlighter band mispositioned when scale is Linear #227

Closed
2 tasks done
emmacunningham opened this issue Jun 4, 2019 · 1 comment · Fixed by #346
Closed
2 tasks done

Crosshairs hover tooltip & highlighter band mispositioned when scale is Linear #227

emmacunningham opened this issue Jun 4, 2019 · 1 comment · Fixed by #346
Labels
bug Something isn't working :chart Chart element related issue released Issue released publicly

Comments

@emmacunningham
Copy link
Contributor

emmacunningham commented Jun 4, 2019 •
edited
Loading

Describe the bug
When hovering over a clustered series, if the scale type is Scale.Linear, then the hover tooltip and highlighter appear for the next cluster when you hover past the center part of the band.

bars_hover

To Reproduce
Steps to reproduce the behavior:

  1. Create a chart with clustered bars (either multiple BarSeriesSpecs or single BarSeriesSpec with splitSeriesAccessors) with xScaleType={ScaleType.Linear}.
  2. Hover over first band, notice that as you hover over past the halfway point but still in the first band, the tooltip & band highlighter appear for the second band, not the first.

Note that if you change the scale type to ScaleType.Ordinal, the hover state appear correctly positioned.

Expected behavior
Tooltip & band positioning should match how they appear correctly for Scale.Ordinal.

bars_hover_correct

Screenshots
See above

Version (please complete the following information):

  • OS: all
  • Browser: all
  • Elastic Charts: v4.2.6

Additional context

Errors in browser console
None

Kibana Cross Issues
None

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@emmacunningham emmacunningham added bug Something isn't working :chart Chart element related issue labels Jun 4, 2019
@emmacunningham emmacunningham mentioned this issue Jun 10, 2019
Closed
5 tasks
@emmacunningham emmacunningham self-assigned this Jun 10, 2019
@nickofthyme nickofthyme mentioned this issue Aug 19, 2019
Closed
3 tasks
markov00 added a commit to markov00/elastic-charts that referenced this issue Aug 25, 2019
@markov00
fix(scales): bisect correctly on continuous scales
629ef13 
This commit fix the wrong behaviour of the current invertWithStep implementation. It also fix the
behaviour of cursor sync between charts with only lines and charts with only bars and empty
intervals.

fix elastic#227, fix elastic#221
@markov00 markov00 mentioned this issue Aug 25, 2019
Merged
4 tasks
markov00 added a commit that referenced this issue Aug 26, 2019
@markov00
fix(scales): bisect correctly on continuous scales (#346)
5112208 
This commit fix the wrong behaviour of the current invertWithStep implementation. It also fix the behaviour of cursor sync between charts with only lines and charts with only bars and empty intervals.
It also removes the annotation dependency on ticks

fix #227, fix #221
markov00 pushed a commit that referenced this issue Aug 26, 2019
@semantic-release-bot
chore(release): 10.3.1 [skip ci]
d47de40 
## [10.3.1](v10.3.0...v10.3.1) (2019-08-26)

### Bug Fixes

* **scales:** bisect correctly on continuous scales ([#346](#346)) ([5112208](5112208)), closes [#227](#227) [#221](#221)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 10.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 26, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 10.3.1 [skip ci]
b0a8818 
## [10.3.1](elastic/elastic-charts@v10.3.0...v10.3.1) (2019-08-26)

### Bug Fixes

* **scales:** bisect correctly on continuous scales ([opensearch-project#346](elastic/elastic-charts#346)) ([0bb5b19](elastic/elastic-charts@0bb5b19)), closes [opensearch-project#227](elastic/elastic-charts#227) [opensearch-project#221](elastic/elastic-charts#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :chart Chart element related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
2 participants
@emmacunningham @markov00