-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(axis_title): remove whitespace with empty axis title #226
Conversation
The whitespace left from an undefined title is removed from the computation of the axis dimension, removing the unneccessary whitespace occupied by an empty title label fix elastic#225
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 97.81% 97.81% +<.01%
==========================================
Files 35 35
Lines 2563 2564 +1
Branches 559 573 +14
==========================================
+ Hits 2507 2508 +1
Misses 49 49
Partials 7 7
Continue to review full report at Codecov.
|
@markov00 Thank you very much for the update! Btw your coverage reports looks very nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally and code LGTM
🎉 This PR is included in version 4.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [4.2.7](elastic/elastic-charts@v4.2.6...v4.2.7) (2019-06-05) ### Bug Fixes * **axis_title:** remove whitespace with empty axis title ([opensearch-project#226](elastic/elastic-charts#226)) ([52a2d49](elastic/elastic-charts@52a2d49)), closes [opensearch-project#225](elastic/elastic-charts#225)
Summary
fix #225
This PR remove the whitespace left from an undefined
title
axis spec.The whitespace is kept if the
title
prop is any string also an empty one. Only if it's undefined, the occupied space is removed.The
Styling->margins and paddings
storybook story is updated with this change. Switch the show label on axis title checkboxs to add or remove the axis title from the chart configurationChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)