Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove title space if title is empty #225

Closed
2 tasks done
markov00 opened this issue Jun 3, 2019 · 1 comment · Fixed by #226
Closed
2 tasks done

Remove title space if title is empty #225

markov00 opened this issue Jun 3, 2019 · 1 comment · Fixed by #226
Assignees
@markov00
Labels
:axis Axis related issue bug Something isn't working released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jun 3, 2019

Describe the bug
If we add an axis with an empty title, the axis dimension is computed independently from the existence of that title or not.
This will cause an additional empty/white space where the title is missing.

To Reproduce
Steps to reproduce the behavior:

  1. Create an chart with a simple axis
  2. Add or remove the title prop from the axis
  3. The white space around the chart will remain the same

Expected behavior
The margin between the chart and the axis labels should be computed taking in consideration the existence or not of a title. If no title is visible and no margin is configured the axis should be touching the edge of the container.

Screenshots
Jun-03-2019 23-54-10

Version (please complete the following information):

  • Elastic Charts: 4.2.6

Additional context
n/a

Errors in browser console
n/a

Kibana Cross Issues
n/a

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working :axis Axis related issue labels Jun 3, 2019
@markov00 markov00 self-assigned this Jun 3, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Jun 3, 2019
@markov00
fix(axis_title): remove whitespace with empty axis title
f381fca 
The whitespace left from an undefined title is removed from the computation of the axis dimension,
removing the unneccessary whitespace occupied by an empty title label

fix elastic#225
@markov00 markov00 mentioned this issue Jun 3, 2019
Merged
5 tasks
markov00 added a commit that referenced this issue Jun 5, 2019
@markov00
fix(axis_title): remove whitespace with empty axis title (#226)
74198dc 
The whitespace left from an undefined title is removed from the computation of the axis dimension, removing the unnecessary whitespace occupied by an empty title label

fix #225
markov00 pushed a commit that referenced this issue Jun 5, 2019
@semantic-release-bot
chore(release): 4.2.7 [skip ci]
efcde34 
## [4.2.7](v4.2.6...v4.2.7) (2019-06-05)

### Bug Fixes

* **axis_title:** remove whitespace with empty axis title ([#226](#226)) ([74198dc](74198dc)), closes [#225](#225)
@markov00
Copy link
Member Author

markov00 commented Jun 5, 2019

🎉 This issue has been resolved in version 4.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 5, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 4.2.7 [skip ci]
3794787 
## [4.2.7](elastic/elastic-charts@v4.2.6...v4.2.7) (2019-06-05)

### Bug Fixes

* **axis_title:** remove whitespace with empty axis title ([opensearch-project#226](elastic/elastic-charts#226)) ([52a2d49](elastic/elastic-charts@52a2d49)), closes [opensearch-project#225](elastic/elastic-charts#225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:axis Axis related issue bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(axis_title): remove whitespace with empty axis title markov00/elastic-charts
1 participant
@markov00