Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial changes to a theme #201

Closed
3 tasks done
markov00 opened this issue Apr 30, 2019 · 1 comment · Fixed by elastic/kibana#39571
Closed
3 tasks done

Allow partial changes to a theme #201

markov00 opened this issue Apr 30, 2019 · 1 comment · Fixed by elastic/kibana#39571
Assignees
@nickofthyme
Labels
enhancement New feature or request :styling Styling related issue

Comments

@markov00
Copy link
Member

Is your feature request related to a problem? Please describe.
I'd like to change the style of a single property of the theme without having to create the full object that specify the style.

Describe the solution you'd like
I'd like to have a recursive partial type for the Theme object so I can specify only a small portion of the theme.

Describe alternatives you've considered
n/a

Additional context
n/a

Kibana Cross Issues
n/a

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added enhancement New feature or request :styling Styling related issue labels Apr 30, 2019
@kertal kertal self-assigned this May 3, 2019
@cchaos
Copy link
Contributor

cchaos commented Jun 11, 2019

Describe the solution you'd like
Also, be able to use mergeWithDefaultTheme with partial objects.

@nickofthyme nickofthyme self-assigned this Jun 12, 2019
@nickofthyme nickofthyme mentioned this issue Jun 12, 2019
Merged
5 tasks
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Jun 14, 2019
@nickofthyme
feat(theme): allow recursive partial themes
257f649 
Allow recursive partial themes to be passed to the Setting component. Added RecursivePartial global
type.

Issue elastic#201
nickofthyme added a commit that referenced this issue Jun 20, 2019
@nickofthyme
feat(theme): allow recursive partial theme (#239)
d8144ee 
* build(tsconfig): update tsconfigs to extend from a base config

The main tsconfig.json is what vscode uses to parse ts files. Adding a global type would not
available in excluded test files. Extended base tsconfig to current match current build config.

* feat(theme): allow recursive partial themes

Allow recursive partial themes to be passed to the Setting component. Added RecursivePartial global
type.

Issue #201

* test(settings): add tests for partial theme to settings component

* refactor: global type inclusion and story config

Moved global type to be utils. Updated storybook config with custom tsconfig file.

* refactor: remove enum declaration
markov00 pushed a commit that referenced this issue Jun 20, 2019
@semantic-release-bot
chore(release): 6.3.0 [skip ci]
98a87c8 
# [6.3.0](v6.2.0...v6.3.0) (2019-06-20)

### Features

* **theme:** allow recursive partial theme ([#239](#239)) ([d8144ee](d8144ee)), closes [#201](#201)
@alexwizp alexwizp mentioned this issue Jun 25, 2019
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 6.3.0 [skip ci]
9844f30 
# [6.3.0](elastic/elastic-charts@v6.2.0...v6.3.0) (2019-06-20)

### Features

* **theme:** allow recursive partial theme ([opensearch-project#239](elastic/elastic-charts#239)) ([64e9451](elastic/elastic-charts@64e9451)), closes [opensearch-project#201](elastic/elastic-charts#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
enhancement New feature or request :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade @elastic/charts to 7.0.1 alexwizp/kibana
4 participants
@kertal @cchaos @markov00 @nickofthyme