Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid clipping tooltip markers on edges #20

Closed
markov00 opened this issue Jan 31, 2019 · 4 comments · Fixed by #320
Closed

Avoid clipping tooltip markers on edges #20

markov00 opened this issue Jan 31, 2019 · 4 comments · Fixed by #320
Labels
:chart Chart element related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jan 31, 2019 •
edited
Loading

Find a way to fully display tooltip markers near the edges.

screenshot 2019-01-31 at 22 32 13

Kibana Cross Issues:
@markov00 markov00 added enhancement New feature or request kibana cross issue Has a Kibana issue counterpart labels Jan 31, 2019
@markov00 markov00 added the :chart Chart element related issue label Feb 28, 2019
@markov00 markov00 added this to the 7.1 milestone Apr 9, 2019
@markov00
Copy link
Member Author

markov00 commented Apr 9, 2019

The same also happens for points near the edges, with some particular curve types for lines/areas

Screen Shot 2019-04-09 at 11 05 50 AM

@markov00 markov00 mentioned this issue Apr 9, 2019
Closed
93 tasks
@markov00 markov00 modified the milestones: Kibana 7.2, Kibana 7.3 May 22, 2019
@angorayc
Copy link

angorayc commented Jun 4, 2019

Hi @markov00,
Thanks for writing this down.
Just a note that I've got the same issue to the y tick as well.
Screenshot 2019-06-04 at 23 49 33

@markov00 markov00 mentioned this issue Jun 11, 2019
Closed
25 tasks
@cchaos
Copy link
Contributor

cchaos commented Aug 12, 2019

Can we boost this one in priority?

markov00 added a commit to markov00/elastic-charts that referenced this issue Aug 16, 2019
@markov00
fix: remove clippings from chart
56f8b1a 
fix elastic#20
@markov00 markov00 mentioned this issue Aug 16, 2019
Merged
2 tasks
markov00 added a commit that referenced this issue Aug 21, 2019
@markov00
fix: remove clippings from chart geometries (#320)
ed6d0e5 
fix #20
markov00 pushed a commit that referenced this issue Aug 21, 2019
@semantic-release-bot
chore(release): 10.0.0 [skip ci]
b756116 
# [10.0.0](v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([#334](#334)) ([abaa472](abaa472)), closes [#332](#332)
* decuple brush cursor from chart rendering ([#331](#331)) ([789f85a](789f85a)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([#320](#320)) ([ed6d0e5](ed6d0e5)), closes [#20](#20)

### Features

* auto legend resize ([#316](#316)) ([659d27e](659d27e)), closes [#268](#268)
* customize number of axis ticks ([#319](#319)) ([2b838d7](2b838d7))
* **theme:** base theme prop ([#333](#333)) ([a9ff5e1](a9ff5e1)), closes [#292](#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 21, 2019
@benbuzbee benbuzbee mentioned this issue Sep 22, 2019
Closed
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 10.0.0 [skip ci]
e7eb49c 
# [10.0.0](elastic/elastic-charts@v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([opensearch-project#334](elastic/elastic-charts#334)) ([2683333](elastic/elastic-charts@2683333)), closes [opensearch-project#332](elastic/elastic-charts#332)
* decuple brush cursor from chart rendering ([opensearch-project#331](elastic/elastic-charts#331)) ([b5b8dde](elastic/elastic-charts@b5b8dde)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([opensearch-project#320](elastic/elastic-charts#320)) ([497efa4](elastic/elastic-charts@497efa4)), closes [opensearch-project#20](elastic/elastic-charts#20)

### Features

* auto legend resize ([opensearch-project#316](elastic/elastic-charts#316)) ([be4a53d](elastic/elastic-charts@be4a53d)), closes [opensearch-project#268](elastic/elastic-charts#268)
* customize number of axis ticks ([opensearch-project#319](elastic/elastic-charts#319)) ([a7a4ecd](elastic/elastic-charts@a7a4ecd))
* **theme:** base theme prop ([opensearch-project#333](elastic/elastic-charts#333)) ([0b38770](elastic/elastic-charts@0b38770)), closes [opensearch-project#292](elastic/elastic-charts#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:chart Chart element related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove clippings from chart markov00/elastic-charts
3 participants
@cchaos @markov00 @angorayc