fix: cleanup example prop default values #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because SVG renderer is not ready yet, this commit will set the rendering to canvas as default.
BasicSeries component and in general the basic series type was a generic type never used on code.
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 96.62% 96.99% +0.36%
==========================================
Files 36 36
Lines 1867 1861 -6
Branches 251 250 -1
==========================================
+ Hits 1804 1805 +1
+ Misses 54 48 -6
+ Partials 9 8 -1
Continue to review full report at Codecov.
|
|
jenkins, test this |
markov00
pushed a commit
that referenced
this pull request
Apr 16, 2019
## [3.11.2](v3.11.1...v3.11.2) (2019-04-16) ### Bug Fixes * cleanup example prop default values ([#173](#173)) ([ab19df0](ab19df0))
|
🎉 This PR is included in version 3.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.11.2](elastic/elastic-charts@v3.11.1...v3.11.2) (2019-04-16) ### Bug Fixes * cleanup example prop default values ([opensearch-project#173](elastic/elastic-charts#173)) ([0c01661](elastic/elastic-charts@0c01661))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because we started having some users of the library , it's better to start cleaning up a bit the default and the examples to avoid propagate unnecessary styles to new users.
This PR can partially solve the issues described here: #121
This PR cleans up a bit the current examples:
yScaleToDataExtentis default to false, I've removed the unneccessary prop from examplebasicscale type from code. It was never used and can lead to possible misunderstandingsChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Unit tests were updated or added to match the most common scenarios