Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup defaults #121

Closed
8 tasks done
markov00 opened this issue Mar 26, 2019 · 0 comments
Closed
8 tasks done

Cleanup defaults #121

markov00 opened this issue Mar 26, 2019 · 0 comments
Labels
chore :specs Chart specifications related issue

Comments

@markov00
Copy link
Member

markov00 commented Mar 26, 2019

The idea is to have a cleaner chart defaults parameters to minimize the code that a developer needs to wrote to build a basic chart.

Ideally this is the list of tasks thats needs to be implemented:

  • defaults to canvas as renderer
  • provides a default right-bottom axes configuration. If an axis component is added to the JSX, the existing default axis configuration will be removed.
  • default to legend on right shown or hidden
  • change animateData props with a clear name see (fix(animation): re-enabled animateData prop to disable animation #129 (comment))
  • default TooltipType:
    • None can be used on sparklines
    • None is used for chart suggestion previews on new viz editor
    • Follow is best candidate when having more than 4 series (limiting the tooltip height)
  • yScaleToDataExtent={false} used in most charts as default
  • reenable animation props fix(animation): re-enabled animateData prop to disable animation #129
  • convert Chart size into width and height that accept strings
  • [ ] Make the curve type default to the smooth, curved version (CURVE_CATMULL_ROM)
    ...
@markov00 markov00 added enhancement New feature or request chore :specs Chart specifications related issue labels Mar 26, 2019
@markov00 markov00 self-assigned this Mar 27, 2019
@markov00 markov00 removed the enhancement New feature or request label Mar 27, 2019
@markov00 markov00 removed their assignment Apr 1, 2019
@markov00 markov00 mentioned this issue Jun 11, 2019
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore :specs Chart specifications related issue
Projects
None yet
Development

No branches or pull requests

1 participant